Home > How-to Guides, Utilities And Other Useful Things > Prevent SQL Injection Attacks in PHP Applications

Prevent SQL Injection Attacks in PHP Applications


Ok, some quick background before we get started. Let’s say you have a search bar in your PHP-based web site to help people find items, which ties back to your database. Behind your search bar is some code and a query, something like

$query = "SELECT * FROM ITEMS_TABLE WHERE ITEM_NAME LIKE" . $mySearchBarString .";";

So a user provides some string, like ‘Xbox,’ and it finds all items with ‘Xbox’ in the name. Lovely. But what if the user enters this:

blah; SET @tables = NULL;
SELECT GROUP_CONCAT(table_schema, '.', table_name) INTO @tables FROM information_schema.tables;
SET @tables = CONCAT('DROP TABLE ', @tables);
PREPARE stmt1 FROM @tables;
EXECUTE stmt1;
DEALLOCATE PREPARE stmt1;

For those who can’t read SQL, here’s the short version – an attacker just dropped ALL of your databases, in all schemas. Whoops. This is your face right now:

We’re not going to let this happen to us, because losing and replacing that data seems like a lot of work, and we all have better things to do than restore backups and try to explain data loss to end users.

Let’s review some options.

Escape Special Characters

Good news – this is a super easy method in PHP. Bad news – it doesn’t protect against all SQL injection attacks. To implement, simply pass your users’ input through the mysql_real_escape_string function and assign it to a new variable. Then use that variable in your query. For example, let’s assume a user has posted some input from a form, which we’ll grab with the $_POST[x] variable:

$userInput = mysql_real_escape_string($_POST[some_input]);
$query = "SELECT * FROM ITEMS_TABLE WHERE ITEM_NAME LIKE" . $userInput .";";

Simple! However, mysql_real_escape_string was created primarily to sanitize inputs, not give 100% protection against SQL injection attacks. Clever attackers can input HTML into your database, setting you up for cross-site scripting attacks. mysql_real_escape_string also doesn’t escape the percentage sign (%), the wildcard in SQL, leaving you vulnerable.

Just to be clear – don’t use myql_escape_string, as it is also vulnerable to multi-byte character attacks. At the very least, use mysql_real_escape_string.

MySQLi and Prepared Statements

This post is already getting long-winded, so I’ll be brief. Using prepared statements is a best practice for a boatload of reasons. The advantage is that you convert your users’ string input into a parameter object. It is 100% immune to SQL injection, because the input isn’t concatenated to the query, it’s treated as an object. You can use either MySQLi or PDO prepared statements, both are acceptable. Here’s a quick example of using MySQLi and prepared statements from my scratch-space website:

<?php
//set database connection
$mysqli = new mysqli("domain.com","username","password","database_name");
//open database connection; if connection fails, echo the mysql error
if ($mysqli->connect_errno) {
 echo "Failed to connect to MySQL: (" . $mysqli->connect_errno . ") " . $mysqli->connect_error;
}
//check if there is an HTTP POST variable; if one exists, then we need to do the insert; otherwise, don't insert anything
if (isset($_POST["orgName"])) {
 /* Prepared statement, stage 1: prepare */
 if (!($stmt = $mysqli->prepare("INSERT INTO appgen (orgName, motto, number, map, site, body) VALUES (?, ?, ?, ?, ?, ?)"))) {
 echo "Error while preparing statement";
 }
 /* Prepared statement, stage 2: bind and execute */
 if (!$stmt->bind_param("ssssss", $_POST[orgName], $_POST[motto], $_POST[number], $_POST[map], $_POST[site], $_POST[body])) {
 echo "Binding parameters failed: (" . $stmt->errno . ") " . $stmt->error;
 }

if (!$stmt->execute()) {
 echo "Execute failed: (" . $stmt->errno . ") " . $stmt->error;
 }
 else{
 echo "<script>alert('Record added!');</script>";
 }
}
?>

I think most of the code is pretty straightforward, but one thing that tripped me up is the “bind_param” function. The first argument in quotes is actually the data types of all of the parameters you want to bind. Each letter, in sequential order, represents the datatype  of the corresponding parameter. There are only four supported datatypes, i for integer, d for double, s for string, and b for BLOB. So, for example, if I wanted to prepare an insert statement to insert an integer primary key, a string name, a decimal price, and an image BLOB, my code would look something like this:

<?php
...
if (!($stmt = $mysqli->prepare("INSERT INTO table (id, name, price, image) VALUES (?, ?, ?, ?)"))) {
 echo "Error while preparing statement";
}
/* Prepared statement, stage 2: bind and execute */
if (!$stmt->bind_param("isdb", 1,"Xbox", 299.99, image_binary)) {
 echo "Binding parameters failed: (" . $stmt->errno . ") " . $stmt->error;
}
...
?>

Also notice that the number of question marks should be the same as the number of parameters you are binding. The documentation at php.net is pretty good, but not great. If you have any questions or issues with this, please feel free to leave a comment.

As always, hope this was helpful!

Advertisements
  1. tj
    November 26, 2012 at 09:13

    Your source code got kind of messed up with quotes, greater thans, and less thans.

    • November 26, 2012 at 09:41

      Thanks for the heads up, this god forsaken WP sourcecode tag loves to make a fool of me. It likes to switch to all of the ASCII codes when the post gets published at a later date.

  1. No trackbacks yet.

Care to share your two cents?

Fill in your details below or click an icon to log in:

WordPress.com Logo

You are commenting using your WordPress.com account. Log Out / Change )

Twitter picture

You are commenting using your Twitter account. Log Out / Change )

Facebook photo

You are commenting using your Facebook account. Log Out / Change )

Google+ photo

You are commenting using your Google+ account. Log Out / Change )

Connecting to %s

%d bloggers like this: